Still LGTM
http://codereview.chromium.org/8519002/diff/16001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/8519002/diff/16001/test/cctest/test-api.cc#newcode13430 test/cctest/test-api.cc:13430: } Can we test that the heap is now much smaller? http://codereview.chromium.org/8519002/diff/16001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): http://codereview.chromium.org/8519002/diff/16001/test/cctest/test-heap.cc#newcode1320 test/cctest/test-heap.cc:1320: CHECK(new_size < old_size); Can we tighten this assertion? It should have collected a lot of memory by this time. Perhaps we can insist that it has collected half? http://codereview.chromium.org/8519002/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
