LGTM. Don't bother removing PartialPreParse now. It should go away eventually, but there is no rush.
http://codereview.chromium.org/8725001/diff/2001/src/ast.h File src/ast.h (right): http://codereview.chromium.org/8725001/diff/2001/src/ast.h#newcode1179 src/ast.h:1179: friend class Rewriter; Is it really necessary to make Rewriter a friend? Just make the generic constructor public instead. If someone outside needs to use the code, it probably shouldn't be private. http://codereview.chromium.org/8725001/diff/2001/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/8725001/diff/2001/src/parser.cc#newcode5544 src/parser.cc:5544: ScriptDataImpl* ParserApi::PartialPreParse(Handle<String> source, For what it's worth, there is no longer any need for a PartialPreParse function, or partial preparsing functionality. PartialPreParse was a smaller version of the offline preparser, used only for preparsing just before parsing. That shouldn't be done any more. The PartialParserRecorder can be deleted too, since the inline lazy function body "preparsing" doesn't use it. http://codereview.chromium.org/8725001/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
