LGTM with comments addressed Please also add cctest that ensures that we are not leaking memory.
http://codereview.chromium.org/8892002/diff/8001/src/type-info.cc File src/type-info.cc (right): http://codereview.chromium.org/8892002/diff/8001/src/type-info.cc#newcode458 src/type-info.cc:458: add empty line http://codereview.chromium.org/8892002/diff/8001/src/type-info.h File src/type-info.h (right): http://codereview.chromium.org/8892002/diff/8001/src/type-info.h#newcode259 src/type-info.h:259: static bool InSameContext(Handle<Map> map, Handle<Context> global_context); I would better call it: WillRetainDifferentContext or something like this (and invert true and false) because it returns true if it can't determine context for example. This name would also reflect it's purpose (you should also add a comment why this function&filtering was introduced). http://codereview.chromium.org/8892002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
