LGTM with nits
http://codereview.chromium.org/8983016/diff/1/src/isolate.h File src/isolate.h (right): http://codereview.chromium.org/8983016/diff/1/src/isolate.h#newcode111 src/isolate.h:111: if (isolate->has_scheduled_exception()) { \ We should probably always use parentheses around arguments in macros to avoid surprises regarding operator predences. Furthermore, "isolate" is used twice in the expansion, so using a temp variable for it (with an unlikely name, hygienic macros FTW!!) is a bit safer. http://codereview.chromium.org/8983016/diff/1/src/isolate.h#newcode118 src/isolate.h:118: if (call.is_null()) { \ Parentheses again in this macro... http://codereview.chromium.org/8983016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
