You don't like them "one bit" or you don't like them "a little bit"? ;)
On Tue, Jan 10, 2012 at 4:28 PM, <[email protected]> wrote: > lgtm > > please add a test in a separate revision > > also please when transitioning from js -> c and exiting topmost js frame > check > that d14 is 0.0. > > > http://codereview.chromium.**org/9114038/diff/1/src/arm/**assembler-arm.h<http://codereview.chromium.org/9114038/diff/1/src/arm/assembler-arm.h> > File src/arm/assembler-arm.h (right): > > http://codereview.chromium.**org/9114038/diff/1/src/arm/** > assembler-arm.h#newcode180<http://codereview.chromium.org/9114038/diff/1/src/arm/assembler-arm.h#newcode180> > src/arm/assembler-arm.h:180: ASSERT(reg.code() != 14 && reg.code() != > 15); > I don't like this magic constants a bit. > > http://codereview.chromium.**org/9114038/<http://codereview.chromium.org/9114038/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
