http://codereview.chromium.org/9167011/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right):
http://codereview.chromium.org/9167011/diff/1/src/hydrogen-instructions.h#newcode3014 src/hydrogen-instructions.h:3014: : Representation::None(); On 2012/01/11 08:10:40, Jakob wrote:
"return Representation::Tagged();" should suffice, as index == 0 is
always true. Done. http://codereview.chromium.org/9167011/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): http://codereview.chromium.org/9167011/diff/1/src/ia32/lithium-ia32.cc#newcode1479 src/ia32/lithium-ia32.cc:1479: CAN_DEOPTIMIZE_EAGERLY); On 2012/01/11 09:16:28, fschneider wrote:
Since you don't have a DeoptimizeIf in the generated code, you need CANNOT_DEOPTIMIZE_EAGERLY here (which is the default).
Good catch! Thanks Florian. Done. http://codereview.chromium.org/9167011/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/9167011/diff/1/src/x64/lithium-codegen-x64.cc#newcode2938 src/x64/lithium-codegen-x64.cc:2938: Register global_object = rdx; On 2012/01/11 08:10:40, Jakob wrote:
Unused variable. Also, s/rdx/rcx/.
Done. http://codereview.chromium.org/9167011/diff/1/src/x64/lithium-codegen-x64.cc#newcode2945 src/x64/lithium-codegen-x64.cc:2945: #ifdef _WIN64 On 2012/01/11 08:10:40, Jakob wrote:
If you made use of the |global_object| variable defined above, you
wouldn't need
this #ifdef.
Whoops. Thanks Jakob, that was indeed the intention. http://codereview.chromium.org/9167011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
