LGTM
http://codereview.chromium.org/9231017/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/9231017/diff/1/src/runtime.cc#newcode3292 src/runtime.cc:3292: for (int i = 0; i < 2; i++) { I think this would be clearer without the loop, just duplicating the call. http://codereview.chromium.org/9231017/diff/1/test/mjsunit/string-replace-one-char.js File test/mjsunit/string-replace-one-char.js (right): http://codereview.chromium.org/9231017/diff/1/test/mjsunit/string-replace-one-char.js#newcode39 test/mjsunit/string-replace-one-char.js:39: "$", "###"); It would be nice to test with a replacement string like "x$0x" to see that the '$' detection is working. http://codereview.chromium.org/9231017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
