LGTM.
https://chromiumcodereview.appspot.com/9221011/diff/19001/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/9221011/diff/19001/src/ast.h#newcode148 src/ast.h:148: kDontCrankshaft, To be pedantic (everybody loves that), "Crankshaft" is the name of the entire backend, not just the optimizing compiler. And it's not a verb anyway. I suggest "kDontOptimize". https://chromiumcodereview.appspot.com/9221011/diff/19001/src/ast.h#newcode161 src/ast.h:161: explicit AstProperties(const AstProperties& other) Default copy constructor and assignment operator should do the right thing. https://chromiumcodereview.appspot.com/9221011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
