LGTM with some comments. I will fix everything myself and land.
Thank you for the patch. http://codereview.chromium.org/9372083/diff/1/src/platform-win32.cc File src/platform-win32.cc (right): http://codereview.chromium.org/9372083/diff/1/src/platform-win32.cc#newcode832 src/platform-win32.cc:832: one more new line http://codereview.chromium.org/9372083/diff/1/src/platform-win32.cc#newcode851 src/platform-win32.cc:851: one more new line http://codereview.chromium.org/9372083/diff/1/src/platform-win32.cc#newcode865 src/platform-win32.cc:865: address = OS::GetRandomAddr(); I don't think GetRandomAddr has to be member of OS it could as well be just a static global function. http://codereview.chromium.org/9372083/diff/1/src/platform-win32.cc#newcode1487 src/platform-win32.cc:1487: mbase = VirtualAlloc(NULL, size, MEM_RESERVE, PAGE_NOACCESS); we do not omit {} for if-s that span several lines. http://codereview.chromium.org/9372083/diff/1/src/platform-win32.cc#newcode1488 src/platform-win32.cc:1488: return mbase; I would abstract loop and last attempt into a function and call it from two different places. http://codereview.chromium.org/9372083/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
