https://chromiumcodereview.appspot.com/9433031/diff/1/src/char-predicates.h
File src/char-predicates.h (right):

https://chromiumcodereview.appspot.com/9433031/diff/1/src/char-predicates.h#newcode60
src/char-predicates.h:60: || c == 0x200D
Good thought.
I'd prefer moving the number (digit, really) test before the ZWNJ/ZWJ
test, since digits are probably more likely to be in actual identifiers.


Perhaps add a comment after the constants (like "  // U+200C is
ZeroWidthNonJoiner.").

https://chromiumcodereview.appspot.com/9433031/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to