https://chromiumcodereview.appspot.com/9696035/diff/1/test/mjsunit/regress/regress-115452.js File test/mjsunit/regress/regress-115452.js (right):
https://chromiumcodereview.appspot.com/9696035/diff/1/test/mjsunit/regress/regress-115452.js#newcode37 test/mjsunit/regress/regress-115452.js:37: assertEquals(1, this.foobl); On 2012/03/14 13:38:07, Michael Starzinger wrote:
Better use assertSame() here.
Done. https://chromiumcodereview.appspot.com/9696035/diff/1/test/mjsunit/regress/regress-115452.js#newcode42 test/mjsunit/regress/regress-115452.js:42: assertEquals(1, this.foobl); On 2012/03/14 13:38:07, Michael Starzinger wrote:
Likewise.
Done. https://chromiumcodereview.appspot.com/9696035/diff/1/test/mjsunit/regress/regress-115452.js#newcode46 test/mjsunit/regress/regress-115452.js:46: eval("function foobl() {}"); On 2012/03/14 13:38:07, Michael Starzinger wrote:
Why do you test this twice? Isn't once sufficient?
You would think so, but you never know whether the first one somehow affects something in the background that would make the second succeed. :) https://chromiumcodereview.appspot.com/9696035/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
