Reviewers: Yang,
Message:
On 2012/03/13 15:57:00, Yang wrote:
I don't see why this change is necessary. The test script runs fine with
Python
2.6 on Windows for me.
I am using python 2.7 and it treats the entire command line as the binary
to be
executes, e.g. it starts looking for "scons mode=debug" instead of "scons".
Description:
Make tools/test.py work on Windows
It adds too many quotes around shell commands.
Please review this at http://codereview.chromium.org/9691029/
Affected files:
M tools/test.py
Index: tools/test.py
diff --git a/tools/test.py b/tools/test.py
index
951afcc85da02791a0d95cbf636858a98257442f..6645351ac4ca7d115670c8f863eafbf1d2a26612
100755
--- a/tools/test.py
+++ b/tools/test.py
@@ -472,7 +472,7 @@ def RunProcess(context, timeout, args, **rest):
popen_args = args
prev_error_mode = SEM_INVALID_VALUE
if utils.IsWindows():
- popen_args = '"' + subprocess.list2cmdline(args) + '"'
+ popen_args = subprocess.list2cmdline(args)
if context.suppress_dialogs:
# Try to change the error mode to avoid dialogs on fatal errors.
Don't
# touch any existing error mode flags by merging the existing error
mode.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
