Thanks for the review. Landing.
https://chromiumcodereview.appspot.com/9845019/diff/3001/src/x64/deoptimizer-x64.cc File src/x64/deoptimizer-x64.cc (right): https://chromiumcodereview.appspot.com/9845019/diff/3001/src/x64/deoptimizer-x64.cc#newcode150 src/x64/deoptimizer-x64.cc:150: ASSERT_EQ(kJnsOffsetDebugCode, *(call_target_address - 2)); On 2012/03/26 14:27:06, danno wrote:
Whoa, this was totally non-obvious, perhaps a comment about the
different code
size.
Done. https://chromiumcodereview.appspot.com/9845019/diff/3001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): https://chromiumcodereview.appspot.com/9845019/diff/3001/src/x64/full-codegen-x64.cc#newcode364 src/x64/full-codegen-x64.cc:364: EmitProfilingCounterReset(); On 2012/03/26 14:27:06, danno wrote:
Perhaps you could save code size be doing this in the InterruptStub?
Would make
the generated code smaller. Another CL?
Yeah, in another CL. https://chromiumcodereview.appspot.com/9845019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
