LGTM. I am positively surprised that it is that easy to change the size of
one
page. I would have assumed it would break everything instantly if one tries
that.
http://codereview.chromium.org/9950048/diff/1/src/spaces.cc
File src/spaces.cc (right):
http://codereview.chromium.org/9950048/diff/1/src/spaces.cc#newcode872
src/spaces.cc:872: size = 64 * sizeof(dummy) * KB;
Why not use kPointerSize here?
http://codereview.chromium.org/9950048/diff/1/src/spaces.cc#newcode884
src/spaces.cc:884: if (sizeof(dummy) == 8) {
Why not use kPointerSize here?
http://codereview.chromium.org/9950048/diff/1/src/spaces.h
File src/spaces.h (right):
http://codereview.chromium.org/9950048/diff/1/src/spaces.h#newcode959
src/spaces.h:959: Executability executable,
I know you didn't touch that line, but something is wrong with
indentation here.
http://codereview.chromium.org/9950048/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
