LGTM with comments
https://chromiumcodereview.appspot.com/9950095/diff/4/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/9950095/diff/4/src/runtime.cc#newcode4685 src/runtime.cc:4685: ASSERT(elements_kind == boilerplate->GetElementsKind()); This assertion isn't needed and misleading now (similar to below). https://chromiumcodereview.appspot.com/9950095/diff/4/src/runtime.cc#newcode4698 src/runtime.cc:4698: ASSERT(elements_kind == boilerplate->GetElementsKind()); This will assert when elements_kind is FAST_SMI_ONLY_ELEMENTS but boilerplate->GetElementsKind() is FAST_DOUBLE_ELEMENTS, but that's actually a valid case. https://chromiumcodereview.appspot.com/9950095/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
