https://chromiumcodereview.appspot.com/9950146/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/9950146/diff/1/src/profile-generator.cc#newcode3511 src/profile-generator.cc:3511: static char* itoa(int value, char* buffer) { On 2012/04/04 10:03:31, Mikhail Naganov (Chromium) wrote:
Have you tried IntToCString? It uses Vector, which has overrun asserts
in debug
mode.
IntToCString will place the number into the end of the buffer which wouldn't work for us as we don't know number of digits beforehand. I switched this implementation to Vector<char> so that we have overrun asserts in debug mode. https://chromiumcodereview.appspot.com/9950146/diff/1/src/profile-generator.cc#newcode3568 src/profile-generator.cc:3568: STATIC_CHECK(sizeof(int) == sizeof(entry->type())); // NOLINT On 2012/04/04 11:20:49, alexeif wrote:
If you remove printf these checks are unnecessary.
Done. Removed. https://chromiumcodereview.appspot.com/9950146/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
