https://chromiumcodereview.appspot.com/10031032/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10031032/diff/1/src/profile-generator.cc#newcode1340 src/profile-generator.cc:1340: ASSERT((uint32_t)entries_->length() >= entries_map_.occupancy()); Please use static_cast<uint32_t> https://chromiumcodereview.appspot.com/10031032/diff/1/src/profile-generator.cc#newcode1362 src/profile-generator.cc:1362: // 1. lookup for From address entry in the map and update EntryInfo.addr. From -> |from|, To -> |to| https://chromiumcodereview.appspot.com/10031032/diff/1/src/profile-generator.cc#newcode1372 src/profile-generator.cc:1372: UpdateEntryInfoAddress(to, to_hash, NULL); This is an overhead, we should instead do entries_->at(entry_index).addr = to; below line 1374, this way we will need 1 Lookup less. https://chromiumcodereview.appspot.com/10031032/diff/1/src/profile-generator.cc#newcode1385 src/profile-generator.cc:1385: ASSERT((uint32_t)entries_->length() >= entries_map_.occupancy()); static_cast please. https://chromiumcodereview.appspot.com/10031032/diff/1/src/profile-generator.cc#newcode1396 src/profile-generator.cc:1396: ASSERT((uint32_t)entries_->length() >= entries_map_.occupancy()); ditto https://chromiumcodereview.appspot.com/10031032/diff/1/src/profile-generator.cc#newcode1425 src/profile-generator.cc:1425: ASSERT((uint32_t)entries_->length() == entries_map_.occupancy()); ditto. https://chromiumcodereview.appspot.com/10031032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
