https://chromiumcodereview.appspot.com/10037004/diff/2001/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10037004/diff/2001/src/profile-generator.cc#newcode3621 src/profile-generator.cc:3621: writer_->AddString(JSON_O( Is this object still the first item of 'nodes' array? This is asymmetric to the absence of such meta-information in 'edges' array. Perhaps, we should reserve the first item of 'edges' for this data? This will also eliminate the special case of the item 0. It is not necessary to split the meta-data in this changelist. https://chromiumcodereview.appspot.com/10037004/diff/2001/src/profile-generator.cc#newcode3624 src/profile-generator.cc:3624: JSON_S("type") "," Why are you moving commas to the suffix position? I supposed, having them as a prefix makes you only to change a single line when adding / removing a field. https://chromiumcodereview.appspot.com/10037004/diff/2001/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://chromiumcodereview.appspot.com/10037004/diff/2001/test/cctest/test-heap-profiler.cc#newcode632 test/cctest/test-heap-profiler.cc:632: "parsed.nodes = parsed.nodes.slice(1);\n" Why is this needed? https://chromiumcodereview.appspot.com/10037004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
