lgtm
https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-ia32.cc#newcode272 src/ia32/full-codegen-ia32.cc:272: != Variable::UNALLOCATED); Break line after the operator to be consistent with the surrounding code. Or since scope()->function() is used outside the ASSERT, you could also store it in a local to make the line shorter. https://chromiumcodereview.appspot.com/9704054/diff/1/src/ia32/full-codegen-ia32.cc#newcode754 src/ia32/full-codegen-ia32.cc:754: // The variable in the decl always resides in the current function s/decl/declaration/ https://chromiumcodereview.appspot.com/9704054/diff/1/src/parser.cc File src/parser.cc (right): https://chromiumcodereview.appspot.com/9704054/diff/1/src/parser.cc#newcode4450 src/parser.cc:4450: function_name, fvar_mode, true, Variable::NORMAL, kCreatedInitialized); Maybe break after each parameter and add a short same-line comment to the boolean parameter. https://chromiumcodereview.appspot.com/9704054/diff/1/src/scopes.cc File src/scopes.cc (right): https://chromiumcodereview.appspot.com/9704054/diff/1/src/scopes.cc#newcode423 src/scopes.cc:423: this, name, mode, true, Variable::NORMAL, kCreatedInitialized); Boolean parameter should have a comment. https://chromiumcodereview.appspot.com/9704054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
