On 2012/04/13 11:34:52, Erik Corry wrote:
https://chromiumcodereview.appspot.com/10079004/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://chromiumcodereview.appspot.com/10079004/diff/1/src/x64/stub-cache-x64.cc#newcode1190
src/x64/stub-cache-x64.cc:1190: __ push(kScratchRegister);
In the case where the isolate address is <4Gbytes the old code was
correct and
faster. Worth checking for? A Push(ExternalReference) instruction in the
macro
assembler that checked for the serializer being active and the address
being
under 4Gbytes could do this.
Yes, actually having a Push(ExternalReference) seems like a very good thing
to
have. Good point, I'll implement that in a separate CL.
https://chromiumcodereview.appspot.com/10079004/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
