LGTM.
Two small comments. I can fix them before landing if it makes sense. What
do you
think?
http://codereview.chromium.org/9638018/diff/13001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
http://codereview.chromium.org/9638018/diff/13001/src/arm/lithium-arm.cc#newcode1358
src/arm/lithium-arm.cc:1358:
HConstant::cast(dividend)->HasInteger32Value()) {
This would only occur is in Math.floor(a/b) both a and b are constants.
In this case the division would be folded already, right? So you can
probably leave out this case here.
http://codereview.chromium.org/9638018/diff/13001/test/mjsunit/math-floor-of-div.js
File test/mjsunit/math-floor-of-div.js (right):
http://codereview.chromium.org/9638018/diff/13001/test/mjsunit/math-floor-of-div.js#newcode169
test/mjsunit/math-floor-of-div.js:169: // (values[key] | 0) does not
work anymore as it is optimized by hydrogen.)
I don't understand why +0 is necessary. It's fine, but maybe also
optimized away in the future.
x|0 is optimized into x, but x is still forced to be integer32 because
of the bitwise semantics. Maybe you can still use |0 here?
http://codereview.chromium.org/9638018/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
