Reviewers: danno, Jakob, Michael Starzinger,

Message:
Jakob and Michael, could you please help review this patch? Thanks

Description:
Repair the build for Android on IA in a x64 host platform

There are two issues here:
1) Define the macro 'V8_HOST_ARCH_IA32'
2) Add the option '-m32' for cflags and ldflags like arm

BUG=126614
TEST=

Please review this at http://codereview.chromium.org/10310058/

SVN Base: http://v8.googlecode.com/svn/trunk/

Affected files:
  M     build/common.gypi


Index: build/common.gypi
===================================================================
--- build/common.gypi   (revision 11520)
+++ build/common.gypi   (working copy)
@@ -168,6 +168,19 @@
             'defines': [
               'V8_TARGET_ARCH_IA32',
             ],
+            'conditions': [
+              ['host_arch=="x64" and OS=="android"', {
+                'target_conditions': [
+                  ['_toolset=="host"', {
+                    'cflags': ['-m32'],
+                    'ldflags': ['-m32'],
+                  }],
+                ],
+                'defines': [
+                  'V8_HOST_ARCH_IA32',
+                ],
+              }],
+            ],
           }],
           ['v8_target_arch=="mips"', {
             'defines': [


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to