Reviewers: fschneider, Message: This is necessary for a future change I'd like to make (basically, http://codereview.chromium.org/10386108/ for v8).
https://chromiumcodereview.appspot.com/10310156/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://chromiumcodereview.appspot.com/10310156/diff/1/tools/gyp/v8.gyp#newcode729 tools/gyp/v8.gyp:729: 'V8_SHARED', See here. Description: Simplify v8.gyp. This matches how BUILDING_V8_SHARED is set in other places in this file. No intended functionality change. Please review this at https://chromiumcodereview.appspot.com/10310156/ SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M tools/gyp/v8.gyp Index: tools/gyp/v8.gyp =================================================================== --- tools/gyp/v8.gyp (revision 11551) +++ tools/gyp/v8.gyp (working copy) @@ -58,31 +58,22 @@ # has some sources to link into the component. '../../src/v8dll-main.cc', ], + 'defines': [ + 'V8_SHARED', + 'BUILDING_V8_SHARED', + ], + 'direct_dependent_settings': { + 'defines': [ + 'V8_SHARED', + 'USING_V8_SHARED', + ], + }, 'conditions': [ ['OS=="mac"', { 'xcode_settings': { 'OTHER_LDFLAGS': ['-dynamiclib', '-all_load'] }, }], - ['OS=="win"', { - 'defines': [ - 'BUILDING_V8_SHARED', - ], - 'direct_dependent_settings': { - 'defines': [ - 'USING_V8_SHARED', - ], - }, - }, { - 'defines': [ - 'V8_SHARED', - ], - 'direct_dependent_settings': { - 'defines': [ - 'V8_SHARED', - ], - }, - }], ['soname_version!=""', { 'product_extension': 'so.<(soname_version)', }], @@ -110,27 +101,16 @@ 'dependencies': ['mksnapshot', 'js2c'], }], ['component=="shared_library"', { - 'conditions': [ - ['OS=="win"', { - 'defines': [ - 'BUILDING_V8_SHARED', - ], - 'direct_dependent_settings': { - 'defines': [ - 'USING_V8_SHARED', - ], - }, - }, { - 'defines': [ - 'V8_SHARED', - ], - 'direct_dependent_settings': { - 'defines': [ - 'V8_SHARED', - ], - }, - }], + 'defines': [ + 'V8_SHARED', + 'BUILDING_V8_SHARED', ], + 'direct_dependent_settings': { + 'defines': [ + 'V8_SHARED', + 'USING_V8_SHARED', + ], + }, }], ], 'dependencies': [ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
