LGTM (just a nit). I like that change.
https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.cc#newcode1873 src/mark-compact.cc:1873: if (descriptors->HasEnumCache()) { It's important that we don't forget to mark every object that could be referenced from the header. So a comment about this block explaining that might be a good idea. https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.cc#newcode1900 src/mark-compact.cc:1900: *value_slot); Just pass "value" as the third parameter here. https://chromiumcodereview.appspot.com/10412030/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
