LGTM.
http://codereview.chromium.org/10542137/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/10542137/diff/1/src/x64/lithium-codegen-x64.cc#newcode2281 src/x64/lithium-codegen-x64.cc:2281: CompactEmit(instr->hydrogen()->types(), name, i, isolate()); This basically means we need to do three lookups (instead of two) for each type in the polymorphic dispatch. If that overhead is acceptable I am fine with this implementation, because it's clean. http://codereview.chromium.org/10542137/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
