LGTM (with one nit).

Also do we have test coverage for that, once es52_globals is activated by
default? If not we should add a test case for that.


https://chromiumcodereview.appspot.com/10546166/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10546166/diff/1/src/runtime.cc#newcode1319
src/runtime.cc:1319: } while (!lookup.IsFound() && obj->IsJSObject() &&
Can we move the "lookup.IsFound()" condition into the loop before
getting the prototype? That would be cleaner IMHO ...

if (lookup.isFound()) break;

https://chromiumcodereview.appspot.com/10546166/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to