LGTM (with two nits). Mostly rubber-stamped, just made some spot checks.
You are
so lucky that "global" and "native" have the same number of characters.
https://chromiumcodereview.appspot.com/10832342/diff/1/src/contexts.h
File src/contexts.h (right):
https://chromiumcodereview.appspot.com/10832342/diff/1/src/contexts.h#newcode417
src/contexts.h:417: static const int kSize =
Should still fit into one line.
https://chromiumcodereview.appspot.com/10832342/diff/1/src/heap.h
File src/heap.h (right):
https://chromiumcodereview.appspot.com/10832342/diff/1/src/heap.h#newcode67
src/heap.h:67: V(Map, native_context_map, NativeContextMap)
\
Add a few spaces to make the '\'es align.
https://chromiumcodereview.appspot.com/10832342/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
