LGTM (with a few final nits).
As discussed offline, it would be nice to trigger a deopt at the
HCheckFunction
for the getter/setter, but I don't think our current type feedback through
the
ICs is sufficient to actually trigger that.
https://chromiumcodereview.appspot.com/10855098/diff/6036/test/mjsunit/compiler/inline-accessors.js
File test/mjsunit/compiler/inline-accessors.js (right):
https://chromiumcodereview.appspot.com/10855098/diff/6036/test/mjsunit/compiler/inline-accessors.js#newcode74
test/mjsunit/compiler/inline-accessors.js:74: TestInlinedGetter(context,
obj, expected);
Can we add assertFalse(expectException) after the test?
https://chromiumcodereview.appspot.com/10855098/diff/6036/test/mjsunit/compiler/inline-accessors.js#newcode150
test/mjsunit/compiler/inline-accessors.js:150:
TestGetterInAllContexts(getter4, obj, undefined);
Can we add the fourth expectException argument here as well?
https://chromiumcodereview.appspot.com/10855098/diff/6036/test/mjsunit/compiler/inline-accessors.js#newcode152
test/mjsunit/compiler/inline-accessors.js:152:
TestGetterInAllContexts(getter4, obj, undefined);
Likewise.
https://chromiumcodereview.appspot.com/10855098/diff/6036/test/mjsunit/compiler/inline-accessors.js#newcode234
test/mjsunit/compiler/inline-accessors.js:234:
TestInlinedSetter(context, obj, value, expected);
Likewise.
https://chromiumcodereview.appspot.com/10855098/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
