On 2012/08/22 14:29:49, ulan wrote:
Could you please check that with this CL we still get compilation cache hits
if
we reload a webpage in Chrome?

I checked with Chromium HEAD and a few reloads, and it had almost identical hit
logs before and after the change.

I think this should all work out. There are three main scenarios I see:

1. Reload always operates in the empty environment, i.e. always sees the same
bare native context, such that cache hits aren't be affected.

2. Likewise, any page that does not define something in the global lexical scope (i.e. not using let, Harmony const, module) shouldn't be affected, because empty
contexts aren't represented.

3. But even a page that _does_ use global lexical scope (i.e. future ES6
applications) still remains cachable as long as all its scripts with lexical
content are executed in a deterministic (i.e. repeatable) order. For script
tags, that always is the case.

Through reflective loads it will probably be possible to defeat all this, but
then you're asking for it. :)


http://codereview.chromium.org/10878007/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to