Regarding inlined functions: Crankshaft keeps a stack of FunctionStates
with an
entry for each inlining level, and each state has its own CompilationInfo.
Therefore we don't attribute things to the wrong level, but I think we might
lose some info when popping the stack. But I have to admit that I can't
come up
with a good repro. :-)
Landing...
http://codereview.chromium.org/10868106/diff/4001/src/lithium.cc
File src/lithium.cc (right):
http://codereview.chromium.org/10868106/diff/4001/src/lithium.cc#newcode393
src/lithium.cc:393: LChunk* LChunk::NewChunk(HGraph* graph,
CompilationInfo* info) {
On 2012/08/27 14:26:02, Jakob wrote:
Instead of passing in |info|, can't you just use graph->info() (as
line 403 does
anyway)?
Good point, I missed that one after refactoring back and forth. Not
needing another argument is a good sign that CompilationInfo is indeed
the right place to keep the bailout reason. Done.
http://codereview.chromium.org/10868106/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
