lgtm
http://codereview.chromium.org/10886012/diff/1/src/messages.js File src/messages.js (right): http://codereview.chromium.org/10886012/diff/1/src/messages.js#newcode770 src/messages.js:770: var getter_function = fun; Is there any reason why you can't simply use fun without creating a separate variable? If there is one: please add a comment explaining that, otherwise: please use fun [possibly renaming it into make_value, value_factory or something] http://codereview.chromium.org/10886012/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): http://codereview.chromium.org/10886012/diff/1/test/cctest/test-heap.cc#newcode2238 test/cctest/test-heap.cc:2238: delete resource; thanks for writing a test! http://codereview.chromium.org/10886012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
