LGTM with a nit and a remark: In general, I like this CL, the call sites of
the
predicates are much clearer now. Nevertheless, I don't like enums with
global
functions working on them, this is basically FORTRAN in 2012. ;-) Making
VariableMode a real class and move the global functions into it is much
cleaner
IMHO, groups things together which belong together, and doesn't involve any
runtime cost. But of course I know that this low-level style was not
introduced
by this CL... :-P
http://codereview.chromium.org/10897010/diff/1/src/v8globals.h
File src/v8globals.h (right):
http://codereview.chromium.org/10897010/diff/1/src/v8globals.h#newcode482
src/v8globals.h:482: enum VariableMode {
Add a warning comment here that the order of the enums matters.
http://codereview.chromium.org/10897010/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
