LGTM.
When the support is added to the embedder I would suggest changing the
default
in V8 so that liveedit is off by default.
http://codereview.chromium.org/10875072/diff/1/include/v8-debug.h
File include/v8-debug.h (right):
http://codereview.chromium.org/10875072/diff/1/include/v8-debug.h#newcode324
include/v8-debug.h:324: Handle<Value> data = Handle<Value>());
Wrong indentation.
http://codereview.chromium.org/10875072/diff/1/include/v8-debug.h#newcode394
include/v8-debug.h:394: * Optionally enable/disable LiveEdit
functionality for the given Isolate
You don't need the word "Optionally" here.
http://codereview.chromium.org/10875072/diff/1/src/debug.h
File src/debug.h (right):
http://codereview.chromium.org/10875072/diff/1/src/debug.h#newcode876
src/debug.h:876: bool is_live_edit_enabled() const { return
is_live_edit_enabled_; }
The variable should be called live_edit_enabled_ and the getters and
setters should be named in a similar way, with no "is".
http://codereview.chromium.org/10875072/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
