Revision: 12406 Author: [email protected] Date: Wed Aug 29 08:23:48 2012 Log: Revert r12379 (Add checks to external string API).
[email protected] BUG= Review URL: https://chromiumcodereview.appspot.com/10897027 http://code.google.com/p/v8/source/detail?r=12406 Modified: /branches/bleeding_edge/include/v8.h /branches/bleeding_edge/src/api.cc ======================================= --- /branches/bleeding_edge/include/v8.h Tue Aug 28 07:43:28 2012 +++ /branches/bleeding_edge/include/v8.h Wed Aug 29 08:23:48 2012 @@ -2539,7 +2539,7 @@ // Note that the strings passed into this constructor must live as long // as the Extension itself. Extension(const char* name, - const char* source, + const char* source = 0, int dep_count = 0, const char** deps = 0, int source_length = -1); ======================================= --- /branches/bleeding_edge/src/api.cc Tue Aug 28 07:43:28 2012 +++ /branches/bleeding_edge/src/api.cc Wed Aug 29 08:23:48 2012 @@ -537,13 +537,11 @@ : name_(name), source_length_(source_length >= 0 ? source_length : - static_cast<int>(strlen(source))), + (source ? static_cast<int>(strlen(source)) : 0)), source_(source, source_length_), dep_count_(dep_count), deps_(deps), - auto_enable_(false) { - CHECK(source); -} + auto_enable_(false) { } v8::Handle<Primitive> Undefined() { -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
