Thanks, landing.
https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof.sh File tools/android-ll-prof.sh (right): https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof.sh#newcode2 tools/android-ll-prof.sh:2: On 2012/09/06 14:23:16, Michael Starzinger wrote:
Copyright header is missing.
Done. https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof.sh#newcode20 tools/android-ll-prof.sh:20: BASE=`pwd` On 2012/09/06 14:23:16, Michael Starzinger wrote:
You could use the following to compute the base path and not rely on
the current
directory being the v8 checkout.
tools_path=`cd $(dirname "$0");pwd`
Done. https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof.sh#newcode21 tools/android-ll-prof.sh:21: DEPLOY=$BASE/deploy On 2012/09/06 14:23:16, Michael Starzinger wrote:
Put quotes around the value of DEPLOY.
Done. https://chromiumcodereview.appspot.com/10908122/diff/1/tools/android-ll-prof.sh#newcode39 tools/android-ll-prof.sh:39: TOOLCHAIN=${ANDROID_NDK_ROOT}/toolchains/$ARCH/prebuilt/linux-x86/bin On 2012/09/06 14:23:16, Michael Starzinger wrote:
Put quotes around the value of TOOLCHAIN.
Done. https://chromiumcodereview.appspot.com/10908122/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
