Reviewers: Michael Starzinger,
Message:
Hi Michael,
This changeset is actually pretty simple: eliminate the profusion of
different
H<Load|Store>Keyed... classes, and the same for the Lithium classes.
Caveats:
1) Nothing intelligent is happening regarding hoisting or recognizing the
common
ElementKind in the lattice that should be shared by a phi. That should be
after
this basic refactoring.
2) There are 2 failing mjsunit tests, related to the LoadKeyed changes,
under
investigation.
3) A set of TODOs are sprinkled around representing questions. In parallel
with
any of your comments I'm addressing those...any insight is helpful.
4) I can't build mips or mipsel (compile errors, even in master branch). Any
advice for this?
Thanks!
--Michael
Description:
Consolidated all the key store/load classes in the Hydrogen and Lithium
space into just two:
HLoadKeyed/HLoadKeyedGeneric and HStoreKeyed/HStoreKeyedGeneric
LLoadKeyed/LLoadKeyedGeneric and LStoreKeyed/LStoreKeyedGeneric
BUG=
Please review this at https://codereview.chromium.org/11238016/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/lithium-arm.h
M src/arm/lithium-arm.cc
M src/arm/lithium-codegen-arm.h
M src/arm/lithium-codegen-arm.cc
M src/hydrogen-instructions.h
M src/hydrogen-instructions.cc
M src/hydrogen.cc
M src/ia32/lithium-codegen-ia32.h
M src/ia32/lithium-codegen-ia32.cc
M src/ia32/lithium-ia32.h
M src/ia32/lithium-ia32.cc
M src/mips/lithium-codegen-mips.h
M src/mips/lithium-codegen-mips.cc
M src/mips/lithium-mips.h
M src/mips/lithium-mips.cc
M src/x64/lithium-codegen-x64.h
M src/x64/lithium-codegen-x64.cc
M src/x64/lithium-x64.h
M src/x64/lithium-x64.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
