Addressed comments, landing.
http://codereview.chromium.org/11189091/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): http://codereview.chromium.org/11189091/diff/1/src/deoptimizer.cc#newcode1454 src/deoptimizer.cc:1454: while (!current->IsUndefined()) { On 2012/10/21 19:56:15, danno wrote:
Why not current != undefined, if you already have it?
Done. http://codereview.chromium.org/11189091/diff/1/src/deoptimizer.cc#newcode1469 src/deoptimizer.cc:1469: if (head != context->get(Context::OPTIMIZED_FUNCTIONS_LIST)) { On 2012/10/21 19:56:15, danno wrote:
If this extra compare just to avoid a write barrier? Otherwise, why
not simply
always set the head?
Yep, I think head will be unchanged most of the time. http://codereview.chromium.org/11189091/diff/1/src/deoptimizer.cc#newcode1485 src/deoptimizer.cc:1485: while (!current->IsUndefined()) { On 2012/10/21 19:56:15, danno wrote:
Why not current != undefined, if you already have it?
Done. http://codereview.chromium.org/11189091/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
