LGTM with comments. Please wait to land this until bleeding_edge re-opens.
http://codereview.chromium.org/11238016/diff/23001/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/11238016/diff/23001/src/arm/lithium-arm.cc#newcode1855 src/arm/lithium-arm.cc:1855: HLoadKeyed* instr) { nit: this can be on the line before http://codereview.chromium.org/11238016/diff/23001/src/arm/lithium-arm.cc#newcode1903 src/arm/lithium-arm.cc:1903: HStoreKeyed* instr) { nit: put on previous line http://codereview.chromium.org/11238016/diff/23001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): http://codereview.chromium.org/11238016/diff/23001/src/hydrogen-instructions.cc#newcode2279 src/hydrogen-instructions.cc:2279: // If value was loaded from unboxed double backing store or nit: fix the comment here, it's now out of date. You should explain that all keyed loads guarantee a non-hole value, so the canonicalization check isn't needed on stores that store a value taken from a keyed load. http://codereview.chromium.org/11238016/diff/23001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/11238016/diff/23001/src/hydrogen-instructions.h#newcode4291 src/hydrogen-instructions.h:4291: bool is_external() const { return nit: bool is_external() const { return ....; } http://codereview.chromium.org/11238016/diff/23001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/11238016/diff/23001/src/hydrogen.cc#newcode2721 src/hydrogen.cc:2721: // Storing a value into an external integer array is a total nit: M-Q is your emacs friend (reflow paragraph) :-) http://codereview.chromium.org/11238016/diff/23001/src/hydrogen.cc#newcode3747 src/hydrogen.cc:3747: nit: Remove extraneous LF http://codereview.chromium.org/11238016/diff/23001/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): http://codereview.chromium.org/11238016/diff/23001/src/ia32/lithium-ia32.cc#newcode1927 src/ia32/lithium-ia32.cc:1927: HLoadKeyed* instr) { nit: put on previous line http://codereview.chromium.org/11238016/diff/23001/src/ia32/lithium-ia32.cc#newcode1974 src/ia32/lithium-ia32.cc:1974: HStoreKeyed* instr) { nit: put on previous line http://codereview.chromium.org/11238016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
