Revision: 12833 Author: [email protected] Date: Tue Oct 30 03:54:44 2012 Log: MIPS: fix mips_arch_variant bug in GYP build.
There is a small bug that causes to build mips32r2 version of v8 as mips32 (r1). This affects only the compiled code. In the default case of building for mips32r2, the compiler flags are the following: -EL -mhard-float -mips32r2 -Wa,-mips32r2 -mips32 -Wa,-mips32 Since the "last flag wins" the object files are compiled as mips32. In a funny twist, the code sourcery lite compilers do not have multi-lib support, and there is a bug that if you tell it to link mips32, it will silently link the object files with mips32r2 libraries, and then the resulting binary is mips32r2. This commit fixes the mips32r1/mips32r2 build. BUG= TEST= Review URL: https://codereview.chromium.org/11289003 Patch from Akos Palfi <[email protected]>. http://code.google.com/p/v8/source/detail?r=12833 Modified: /branches/bleeding_edge/build/common.gypi ======================================= --- /branches/bleeding_edge/build/common.gypi Thu Oct 25 05:18:24 2012 +++ /branches/bleeding_edge/build/common.gypi Tue Oct 30 03:54:44 2012 @@ -205,10 +205,11 @@ ['mips_arch_variant=="mips32r2"', { 'cflags': ['-mips32r2', '-Wa,-mips32r2'], }], + ['mips_arch_variant=="mips32r1"', { + 'cflags': ['-mips32', '-Wa,-mips32'], + }], ['mips_arch_variant=="loongson"', { 'cflags': ['-mips3', '-Wa,-mips3'], - }, { - 'cflags': ['-mips32', '-Wa,-mips32'], }], ], }], -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
