Will work on API tests for this today. And will try to simulate the way the global actually works in the browser, too.
https://codereview.chromium.org/11414094/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/11414094/diff/1/src/runtime.cc#newcode13163 src/runtime.cc:13163: if (obj->IsNull()) return isolate->heap()->undefined_value(); On 2012/11/21 12:43:17, rossberg wrote:
Perhaps you should return false here.
Ah, that's probably a better plan, yes. https://codereview.chromium.org/11414094/diff/1/src/runtime.cc#newcode13175 src/runtime.cc:13175: JSGlobalProxy* global_proxy = NULL; On 2012/11/21 12:43:17, rossberg wrote:
What do you need this for?
Cruft from a previous version before I discovered global_receiver(). Removed. https://codereview.chromium.org/11414094/diff/1/src/runtime.cc#newcode13234 src/runtime.cc:13234: if (key->IsNull()) return isolate->heap()->undefined_value(); On 2012/11/21 12:43:17, rossberg wrote:
Return this.
Woops, fixed. This is one that will be covered by the API test. https://codereview.chromium.org/11414094/diff/1/src/runtime.cc#newcode13248 src/runtime.cc:13248: if (key->IsNull()) return isolate->heap()->undefined_value(); On 2012/11/21 12:43:17, rossberg wrote:
False here, too.
This function wasn't carrying its weight, just removed and implemented in JS. https://codereview.chromium.org/11414094/diff/1/test/mjsunit/harmony/object-observe.js File test/mjsunit/harmony/object-observe.js (right): https://codereview.chromium.org/11414094/diff/1/test/mjsunit/harmony/object-observe.js#newcode61 test/mjsunit/harmony/object-observe.js:61: } catch (e) { } On 2012/11/21 12:43:17, rossberg wrote:
Can you factor this out into a helper function that you use here and
below? Done. https://codereview.chromium.org/11414094/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
