One nit and one suggestion. LGTM.
https://chromiumcodereview.appspot.com/11413142/diff/1/src/builtins.cc File src/builtins.cc (right): https://chromiumcodereview.appspot.com/11413142/diff/1/src/builtins.cc#newcode1045 src/builtins.cc:1045: AssertNoAllocation no_gc; Here you have a scoping brace, for the AssertNoAllocation? Style-wise, I wouldn't do it because it's not done at other sites. https://chromiumcodereview.appspot.com/11413142/diff/1/src/builtins.cc#newcode1210 src/builtins.cc:1210: has_double = has_double || IsFastDoubleElementsKind(arg_kind); This works, but you might like something that I have in my current project: ElementsKind GetUnifiedFastElementsKind(k1,k2); It does the right thing for our elements transition tree. For example DOUBLE and HOLEY_SMI unifies to HOLEY_DOUBLE. You'd still need to keep the has_double boolean for the predicate below. https://chromiumcodereview.appspot.com/11413142/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
