LGTM with a nit.
https://codereview.chromium.org/11415070/diff/2002/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/11415070/diff/2002/src/spaces.h#newcode508 src/spaces.h:508: return reinterpret_cast<Address>(slot) - (reinterpret_cast<Address>(this) + Used the address() helper instead of "reinterpret_cast<Address>(this)". Also if you pull out the cast of slot to Address the code will be easier to read and the condition will fit into one line. https://codereview.chromium.org/11415070/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
