Revision: 13063
Author: [email protected]
Date: Mon Nov 26 08:16:49 2012
Log: Forward white to grey transition only if slot is before the
progress bar of a given object.
BUG=
Review URL: https://codereview.chromium.org/11415070
http://code.google.com/p/v8/source/detail?r=13063
Modified:
/branches/bleeding_edge/src/incremental-marking-inl.h
/branches/bleeding_edge/src/spaces.h
=======================================
--- /branches/bleeding_edge/src/incremental-marking-inl.h Fri Nov 23
04:22:16 2012
+++ /branches/bleeding_edge/src/incremental-marking-inl.h Mon Nov 26
08:16:49 2012
@@ -44,8 +44,12 @@
if (Marking::IsBlack(obj_bit)) {
MemoryChunk* chunk = MemoryChunk::FromAddress(obj->address());
if (chunk->IsFlagSet(MemoryChunk::HAS_PROGRESS_BAR)) {
- WhiteToGreyAndPush(value_heap_obj, value_bit);
- RestartIfNotMarking();
+ if (chunk->IsLeftOfProgressBar(slot)) {
+ WhiteToGreyAndPush(value_heap_obj, value_bit);
+ RestartIfNotMarking();
+ } else {
+ return false;
+ }
} else {
BlackToGreyAndUnshift(obj, obj_bit);
RestartIfNotMarking();
=======================================
--- /branches/bleeding_edge/src/spaces.h Thu Nov 15 09:57:40 2012
+++ /branches/bleeding_edge/src/spaces.h Mon Nov 26 08:16:49 2012
@@ -503,6 +503,12 @@
}
}
+ bool IsLeftOfProgressBar(Object** slot) {
+ Address slot_address = reinterpret_cast<Address>(slot);
+ ASSERT(slot_address > this->address());
+ return (slot_address - this->address() + kObjectStartOffset) <
+ progress_bar();
+ }
static void IncrementLiveBytesFromGC(Address address, int by) {
MemoryChunk::FromAddress(address)->IncrementLiveBytes(by);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
