Reviewers: ulan,
Description:
Remove bogus assertion from idle notification.
Callbacks that run after garbage collection might fire a context dispose
notification and hence increse the counter before we actually reach this
position.
[email protected]
Please review this at https://codereview.chromium.org/11280214/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap.cc
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
84b0f222b8f9b9f9a4b074d5703179fac1ae376b..df66082f82f4ce8841de14ff0791d2493def9741
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -5330,10 +5330,6 @@ bool Heap::IdleNotification(int hint) {
AdvanceIdleIncrementalMarking(step_size);
contexts_disposed_ = 0;
}
- // Make sure that we have no pending context disposals.
- // Take into account that we might have decided to delay full
collection
- // because incremental marking is in progress.
- ASSERT((contexts_disposed_ == 0) |
| !incremental_marking()->IsStopped());
// After context disposal there is likely a lot of garbage remaining,
reset
// the idle notification counters in order to trigger more incremental
GCs
// on subsequent idle notifications.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
