Revision: 13080
Author:   [email protected]
Date:     Wed Nov 28 09:56:17 2012
Log:      Remove bogus assertion from idle notification.

Callbacks that run after garbage collection might fire a context dispose
notification and hence increse the counter before we actually reach this
position.

[email protected]

Review URL: https://codereview.chromium.org/11280214
http://code.google.com/p/v8/source/detail?r=13080

Modified:
 /branches/bleeding_edge/src/heap.cc

=======================================
--- /branches/bleeding_edge/src/heap.cc Wed Nov 28 00:43:10 2012
+++ /branches/bleeding_edge/src/heap.cc Wed Nov 28 09:56:17 2012
@@ -5330,10 +5330,6 @@
       AdvanceIdleIncrementalMarking(step_size);
       contexts_disposed_ = 0;
     }
-    // Make sure that we have no pending context disposals.
- // Take into account that we might have decided to delay full collection
-    // because incremental marking is in progress.
- ASSERT((contexts_disposed_ == 0) | | !incremental_marking()->IsStopped()); // After context disposal there is likely a lot of garbage remaining, reset // the idle notification counters in order to trigger more incremental GCs
     // on subsequent idle notifications.

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to