https://codereview.chromium.org/11348174/diff/2001/src/spaces.cc File src/spaces.cc (right):
https://codereview.chromium.org/11348174/diff/2001/src/spaces.cc#newcode2196 src/spaces.cc:2196: static intptr_t CountFreeListItemsInList(FreeListCategorie* categorie, On 2012/11/27 13:51:53, Michael Starzinger wrote:
I think the code would be easier to read if the static helpers would
still be
based on the FreeListNode and you would just pass in foo_list_.top
into the
static helper. Same applies to the functions below.
Done. Now we just call the method on the given object. https://codereview.chromium.org/11348174/diff/2001/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/11348174/diff/2001/src/spaces.h#newcode1378 src/spaces.h:1378: struct FreeListCategorie { On 2012/11/27 13:51:53, Michael Starzinger wrote:
This should be a proper class with the helper functions as member
methods. Also
naming it "FreeListCategory" is better I guess. Also some comments
above the
class describing it's purpose would be nice.
Done. I refactored the whole free list implementation. https://codereview.chromium.org/11348174/diff/2001/src/spaces.h#newcode1414 src/spaces.h:1414: void Reset(struct FreeListCategorie *categorie); On 2012/11/27 13:51:53, Michael Starzinger wrote:
Move all of these helper functions into FreeListCategory.
Done. https://codereview.chromium.org/11348174/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
