I am not sure that this is the right approach, because only the embedder of
v8
can decide what is really important and what not, so giving a hint via the
normal "inline" seems to be the right thing to do.
Anyway, I can't reproduce the claim that GetAlignedPointerFromInternalField
is
not inlined in Chrome. The following shell magic doesn't produce any output
for
me:
for i in $(find ~/chromium/src/out/Release -name "*.o"); do nm --demangle
--undefined $i | grep --files-with-matches --label=$i
v8::Object::GetAlignedPointerFromInternalField ; done
I built Chrome the usual way via "make -j32 BUILDTYPE=Release" on an x64
gprecise machine. In fact, I verified that *all* functions marked "inline"
are
actually inlined. How did you build your Chrome? Perhaps there is a
difference
in the toolchain etc.? If this is the case we should fix the toolchain or
its
parameters and avoid any ad-hoc changes in the v8 header.
https://codereview.chromium.org/11434021/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
