I recently landed a CL that hooks VMState to catch places where we call
into
DOM, for profiling purposes. It would be bad if those state changes are
removed
entirely. Would it be possible to log state changes only when profiling
flags
are set so that for profiling, I can still rely on those state changes,
but
for
the usual case, we could do away with the atomic increment and decrement?
I don't mind your introducing hooks for profiling as long as they don't slow
down DOM operations in production. Ideally, the profiling hooks would be
compiled out in normal builds, but I'm not sure if that's consistent with
how
you've got profiling set up.
These code paths are extremely hot. We see wins on our benchmarks when we
remove individual branches. IMHO, we should remove these hooks, get
numbers for
the benchmarks we care about, and then make sure we don't regress those
benchmarks when we add back the profiling hooks.
https://codereview.chromium.org/11361275/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
