LGTM with comments.
https://codereview.chromium.org/11437016/diff/2001/src/arm/deoptimizer-arm.cc File src/arm/deoptimizer-arm.cc (right): https://codereview.chromium.org/11437016/diff/2001/src/arm/deoptimizer-arm.cc#newcode117 src/arm/deoptimizer-arm.cc:117: static const int32_t kBranchBeforeStackCheck = 0x2a000001; not needed anymore, please remove. https://codereview.chromium.org/11437016/diff/2001/src/arm/deoptimizer-arm.cc#newcode127 src/arm/deoptimizer-arm.cc:127: // e1 5d 00 0c cmp sp, <limit> please update this comment https://codereview.chromium.org/11437016/diff/2001/src/ia32/deoptimizer-ia32.cc File src/ia32/deoptimizer-ia32.cc (right): https://codereview.chromium.org/11437016/diff/2001/src/ia32/deoptimizer-ia32.cc#newcode213 src/ia32/deoptimizer-ia32.cc:213: static const byte kJaeInstruction = 0x73; not needed anymore, please remove. https://codereview.chromium.org/11437016/diff/2001/src/ia32/deoptimizer-ia32.cc#newcode214 src/ia32/deoptimizer-ia32.cc:214: static const byte kJaeOffset = 0x07; not needed anymore, please remove. https://codereview.chromium.org/11437016/diff/2001/src/ia32/deoptimizer-ia32.cc#newcode229 src/ia32/deoptimizer-ia32.cc:229: // cmp esp, <limit> Please update this comment. Feel free to use pseudo instructions when the details don't matter. https://codereview.chromium.org/11437016/diff/2001/src/x64/deoptimizer-x64.cc File src/x64/deoptimizer-x64.cc (right): https://codereview.chromium.org/11437016/diff/2001/src/x64/deoptimizer-x64.cc#newcode119 src/x64/deoptimizer-x64.cc:119: static const byte kJaeInstruction = 0x73; not needed anymore, please remove. https://codereview.chromium.org/11437016/diff/2001/src/x64/deoptimizer-x64.cc#newcode120 src/x64/deoptimizer-x64.cc:120: static const byte kJaeOffset = 0x07; not needed anymore, please remove. https://codereview.chromium.org/11437016/diff/2001/src/x64/deoptimizer-x64.cc#newcode134 src/x64/deoptimizer-x64.cc:134: // cmp rsp, <limit> please update this comment https://codereview.chromium.org/11437016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
