Revision: 13187
Author: [email protected]
Date: Mon Dec 10 14:02:26 2012
Log: Allow all value types in evaluate additional context
Review URL: https://codereview.chromium.org/11448030
http://code.google.com/p/v8/source/detail?r=13187
Modified:
/branches/bleeding_edge/src/debug-debugger.js
=======================================
--- /branches/bleeding_edge/src/debug-debugger.js Mon Dec 3 13:47:39 2012
+++ /branches/bleeding_edge/src/debug-debugger.js Mon Dec 10 14:02:26 2012
@@ -2143,16 +2143,14 @@
additional_context_object = {};
for (var i = 0; i < additional_context.length; i++) {
var mapping = additional_context[i];
- if (!IS_STRING(mapping.name) || !IS_NUMBER(mapping.handle)) {
+
+ if (!IS_STRING(mapping.name)) {
return response.failed("Context element #" + i +
- " must contain name:string and handle:number");
- }
- var context_value_mirror = LookupMirror(mapping.handle);
- if (!context_value_mirror) {
- return response.failed("Context object '" + mapping.name +
- "' #" + mapping.handle + "# not found");
+ " doesn't contain name:string property");
}
- additional_context_object[mapping.name] =
context_value_mirror.value();
+
+ var raw_value = DebugCommandProcessor.resolveValue_(mapping);
+ additional_context_object[mapping.name] = raw_value;
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
